RFR: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries [v2]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Fri Dec 25 07:25:14 UTC 2020

> Hi all,
> javac fails to read modifiers from the MethodParameters attribute in class files, which prevents plugins from accessing those modifiers across compilation boundaries. Because `com.sun.tools.javac.jvm.ClassReader` doesn't read and store the access flags(modifiers) from MethodParameters attribute.
> This patch fixes it and adds a corresponding test case. All the existing tests of javac passed locally.
> Thank you for taking the time to review.
> Best Regards.

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Modify legal header. Fix typo.


  - all: https://git.openjdk.java.net/jdk/pull/1890/files
  - new: https://git.openjdk.java.net/jdk/pull/1890/files/f064d8e8..a074937f

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1890&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1890&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1890.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1890/head:pull/1890

PR: https://git.openjdk.java.net/jdk/pull/1890

More information about the compiler-dev mailing list