RFR: 8198317: Enhance JavacTool.getTask for flexibility

Jonathan Gibbons jjg at openjdk.java.net
Fri Dec 25 20:53:58 UTC 2020

On Fri, 25 Dec 2020 16:26:39 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

> Hi all,
> This little patch enhances the setting of `Log` in `JavacTool.getTask`.
> Thank you for taking the time to review.
> Best Regards.

As a general rule, all changes should have an accompanying regression test, unless there is a good reason why not.   The set of good reasons has a corresponding list of JBS labels, shown here: http://openjdk.java.net/guide/#noreg

The closest match here would be `noreg-trivial` but I don't think it is close enough to claim that. In other words, I think this change needs a corresponding new test.  It is also not uncommon for small changes like this to more effort to write the test than fixing the underlying issue.


* *Unit test*: insurance against having to writing a regression test later on
* *Regression test*: the penalty for not writing a unit test in the first place


Changes requested by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1896

More information about the compiler-dev mailing list