RFR: 8255757: Javac emits duplicate pool entries on array::clone [v2]
vromero at openjdk.java.net
Thu Dec 31 15:34:57 UTC 2020
On Thu, 31 Dec 2020 10:05:19 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:
>> Hi all,
>> Currently, javac would emit duplicate pool entries when compiling array::clone.
>> This patch fixes it by using a cached field `Map<Type, Symbol> qualifiedSymbolCache;` and adds a corresponding test case.
>> Thank you for taking the time to review.
>> Best Regards.
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> Cleanup variable and useless test code.
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java line 2433:
> 2431: endPosTable = null;
> 2432: nerrs = 0;
> 2433: qualifiedSymbolCache = null;
I meant `qualifiedSymbolCache.clear()` instead of assigning null to it
More information about the compiler-dev