RFR: 8255757: Javac emits duplicate pool entries on array::clone [v3]

Vicente Romero vromero at openjdk.java.net
Thu Dec 31 16:33:58 UTC 2020

On Thu, 31 Dec 2020 16:03:15 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> Hi all,
>> Currently, javac would emit duplicate pool entries when compiling array::clone.
>> This patch fixes it by using a cached field `Map<Type, Symbol> qualifiedSymbolCache;` and adds a corresponding test case.
>> Thank you for taking the time to review.
>> Best Regards.
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Use Map::clear

Marked as reviewed by vromero (Reviewer).

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java line 47:

> 45: import com.sun.tools.javac.tree.JCTree.*;
> 46: 
> 47: import java.util.HashMap;

sorry one final matter of style these imports should come first before all the `com.sun.tools.javac.*` ones, there is no need for another review iteration just please fix it before integrating. Thanks!


PR: https://git.openjdk.java.net/jdk/pull/1912

More information about the compiler-dev mailing list