RFR (backport 11u): JDK-8244763: Update --release 8 symbol information after JSR 337 MR3

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Jul 7 20:36:46 UTC 2020


Looks good to me.

That being said, it looks like the underlying versions of CreateSymbols 
are somewhat different in 11u and 15, which is confirmed by looking at 
the Frames view in the webrevs for mainline and for the backport. The 
differences seem enough that backporting patches seems more 
questionable.  I know we don't backport symbol changes often, but if we 
get to do it again, it might be worth looking at whether we can make the 
different versions of the tool more similar.

-- Jon

On 7/7/20 12:17 PM, Jan Lahoda wrote:
> Hi,
> I'd like to ask for a review of a backport of:
> https://bugs.openjdk.java.net/browse/JDK-8244763
> https://hg.openjdk.java.net/jdk/jdk15/rev/d0b86d63c00f
> The patch unfortunately does not apply cleanly, so manual fixes were 
> needed, but the backport patch should be conceptually the same as the 
> original one.
> Proposed backport webrev:
> http://cr.openjdk.java.net/~jlahoda/8244763/webrev.backport.00/
> Original review thread:
> https://mail.openjdk.java.net/pipermail/compiler-dev/2020-May/014537.html
> Does this look reasonable?
> Thanks,
>     Jan

More information about the compiler-dev mailing list