RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v6]
jlahoda at openjdk.java.net
Wed Nov 4 10:35:02 UTC 2020
On Mon, 2 Nov 2020 18:39:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 46 commits:
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests after records are a final feature.
>> - Fixing tests.
>> - Finalizing removal of record preview hooks.
>> - Merging master into JDK-8250768
>> - Reflecting review comments.
>> - Merge branch 'master' into JDK-8250768
>> - Removing unnecessary cast.
>> - Using a more correct way to get URLs.
>> - ... and 36 more: https://git.openjdk.java.net/jdk/compare/d93e3a7d...2e403900
> src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTaskPool.java line 257:
>> 255: //when patching modules (esp. java.base), it may be impossible to
>> 256: //clear the symbols read from the patch path:
>> 257: polluted |= get(JavaFileManager.class).hasLocation(StandardLocation.PATCH_MODULE_PATH);
> OK, but looks unrelated to primary work
The tests need to inject preview APIs into compilation, and without this tweak, the incorrect values are re-used for tests that use the javac pool. So it is related in the sense it is needed for the tests to pass.
More information about the compiler-dev