RFR: 8254105: allow static nested declarations [v6]
mcimadamore at openjdk.java.net
Wed Nov 4 16:19:56 UTC 2020
On Tue, 3 Nov 2020 19:25:16 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> Please review the fix for [JDK-8254105](https://bugs.openjdk.java.net/browse/JDK-8254105). The intention of the fix is to allow static members to be declared inside inner classes. The spec allowing this change can be seen at [Local and Nested Static Declarations](http://cr.openjdk.java.net/~gbierman/8246771/8246771-20200928/specs/local-statics-jls.html). This change is part of the [Records JEP](https://openjdk.java.net/jeps/395). The idea is to allow not only records to be defined inside inner classes but also interfaces, enums, static classes and methods.
>> PS: the records spec can be accessed here [Record Classes](http://cr.openjdk.java.net/~gbierman/8246771/8246771-20200928/specs/records-jls.html). This patch also adds a test to check the changes in the Records spec to Chapter 13 "Binary Compatibility". I'm OK moving that test to a separate PR.
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> addressing review comments
Changes look good
Marked as reviewed by mcimadamore (Reviewer).
More information about the compiler-dev