RFR: 8255561: add tests to check binary compatibility rules for records [v2]

Vicente Romero vromero at openjdk.java.net
Fri Nov 6 05:18:11 UTC 2020

On Thu, 5 Nov 2020 22:08:22 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>>   addressing review comments
> test/langtools/tools/javac/records/RecordsBinaryCompatibilityTests.java line 251:
>> 249:             String clientCode,
>> 250:             boolean shouldFail,
>> 251:             String expectedError) throws Exception {
> Since the expected error always seems to be the name of a class, you could make the type of the parameter be `Class<?>` and then pass class literals as arguments. Inside the method, you get use `getName()` to get the name you expect to see.

I have uploaded a new iteration addressing your comments, thanks


PR: https://git.openjdk.java.net/jdk/pull/1082

More information about the compiler-dev mailing list