RFR: 8256308: Send arguments to javac server in a config file [v6]

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Nov 18 00:07:11 UTC 2020

On Tue, 17 Nov 2020 23:00:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>   Fix whitespace issues
> There seems to be much more here than there needs to be.
> If the issue is just long command lines, then the obvious/conventional solution would be to use @files, which would be a tiny change to the sjavac source code, to insert a single call to `CommandLine.parse` to expand any @file arguments on the command line.
> So, before reading all the various details in this proposed change, is there any reason why the simple @file solution cannot be used?

The main issue is not the long command lines. Getting shorter command lines is nice, but more a side-effect.

The real driver here is the awkward encoding of the command line, with spaces replaced by %20. This makes it impossible to parse the --server option to Java and properly replace unix paths with Windows paths, in the way that is needed by the upcoming changes to how we build on Windows.


PR: https://git.openjdk.java.net/jdk/pull/1195

More information about the compiler-dev mailing list