RFR: 8246778: Compiler implementation for Sealed Classes (Second Preview)

Jan Lahoda jlahoda at openjdk.java.net
Wed Nov 25 12:43:59 UTC 2020

On Tue, 24 Nov 2020 23:00:05 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> I agree.  This @apiNote needs more clarification to help the readers to understand the context here.    One thing we could do in the Package class description to add a "Package Sealing" section that can also explain that it has no relationship to "sealed classes".
> I added an API note in `Package::isSealed` [1] to clarify sealed package vs sealed class or interface.
> The API note you added in `Class::isSealed` can be clarified in a similar fashion like: "Sealed class or interface has no relationship with {@linkplain Package#isSealed package sealing}".
> [1] https://github.com/openjdk/jdk/commit/3c230b8a

Thanks for that update, Mandy! I've tweaked the API note as per your recommendation. I'll publish a fixed PR later, reflecting the other review comments as well.


PR: https://git.openjdk.java.net/jdk/pull/1227

More information about the compiler-dev mailing list