RFR: 8242652: Throw SkippedException if no JS engine availabe in TestSearchScript [v2]
prappo at openjdk.java.net
Thu Nov 26 16:59:00 UTC 2020
On Thu, 26 Nov 2020 16:54:06 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Note that while the test is skipped correctly if no JS engine is available, the test will currently fail in the presence of a JS engine such as GraalJS. This is fixed by JDK-8244535.
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
> Use existing SkippedException class in TestSearchScript.java
This change looks good to me. Since you've changed `test/langtools/TEST.ROOT`, please make sure all the langtools tests pass (not just `TestSearchScript.java`) before integrating this change.
Marked as reviewed by prappo (Reviewer).
More information about the compiler-dev