RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols [v3]

Jan Lahoda jlahoda at openjdk.java.net
Mon Nov 30 14:27:13 UTC 2020

On Mon, 30 Nov 2020 12:17:46 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>>   Fixing tests on Windows - normalizing line endings.
> make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java line 965:
>> 963:                            new NestMembers_attribute(attributeString, nestMembers));
>> 964:         }
>> 965:         if (header.recordComponents != null && !header.recordComponents.isEmpty()) {
> I am not sure of the exact logic here, but it is perfectly fine for a record attribute to contain zero components, and for the class to still be considered a "record class". But maybe that is not all that significant here? I just want to call it out so that it is considered.

Ah, right - fixed in:

Thanks for the comment!


PR: https://git.openjdk.java.net/jdk/pull/1480

More information about the compiler-dev mailing list