RFR: 8253736: Cleanup some of WorkArounds and usage thereof
vromero at openjdk.java.net
Thu Oct 1 15:21:04 UTC 2020
On Tue, 29 Sep 2020 20:25:27 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> This cleanup is primarily focussed on the WorkArounds class, simplifying/removing code that is no longer required.
> Also, simplified DocLint initialization such that it no longer needs a `JavacTask` and so the initiate code can be
> moved out of `WorkArounds`.
> The "constant value expression" in Utils is simplified to remove a redundant level of enclosing nested class for the
> type-kind visitor.
just a nit comment, no need for another iteration, the changes looks good to me
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java line 117:
> 116: /*
> 117: * TODO: This method exists because of a bug in javac which does not
probably a good idea to include the bug ID here?
Marked as reviewed by vromero (Reviewer).
More information about the compiler-dev