RFR: 8253455: Record Classes javax.lang.model changes [v6]

Joe Darcy darcy at openjdk.java.net
Sat Oct 10 16:57:09 UTC 2020

On Fri, 9 Oct 2020 21:19:23 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Please review the fix for [JDK-8253455](https://bugs.openjdk.java.net/browse/JDK-8253455) which is part of the effort
>> to make records a final feature of the Java Language. The rest of the code has been published in
>> [PR#290](https://github.com/openjdk/jdk/pull/290)  Thanks,
>> Vicente
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>   updating @since from 14 to 16

Marked as reviewed by darcy (Reviewer).

src/java.base/share/classes/jdk/internal/PreviewFeature.java line 65:

> 63:         // necessary for PreviewFeature in JDK 15 to declare the enum constant.
> 64:         TEXT_BLOCKS,
> 65:         /*

It doesn't really matter, but it would look more consistent if TEXT_BLOCKS and RECORDS used the same kind of comment


PR: https://git.openjdk.java.net/jdk/pull/291

More information about the compiler-dev mailing list