RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage

Kevin Rushforth kcr at openjdk.java.net
Tue Oct 13 14:34:20 UTC 2020

On Tue, 13 Oct 2020 13:51:27 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I spot checked it and left a couple comments. The rest looks good. I'll review it in more detail later this week.
> @andyherrick the "reviewer credit" command should not be used in this manner. It is intended for the case where an
> offline review of a PR has been done elsewhere and you wish to record that in the commit. It is not how you ask someone
> to do a review.

You can't directly, so I usually just mention in a comment who I want to review it. If you use their GitHub username it
will notify them (unless they have disabled all notifications). Something like this:

@prrace @kevinrushforth @sashamatveev @alexeysemenyukoracle please review


PR: https://git.openjdk.java.net/jdk/pull/633

More information about the compiler-dev mailing list