RFR: 8273361: InfoOptsTest is failing in tier1
shade at openjdk.java.net
Wed Sep 8 08:16:10 UTC 2021
On Wed, 8 Sep 2021 02:25:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Current test checks that informational messages are not printed twice. The failing tests verifies that by checking `java.specification.version` is not present twice in the version string. Effectively, it searches for `18`. But a second `18` could get to version string from anywhere: the Git hash, the user name, etc. It is failing in current GHA due to Git hash containing `18`.
>> I believe the test should be more conservative: look for more unique strings, and check that the lines start with it. "javac" and "javac full version" seem unique enough. Checking that lines start with "javac" handles the case of accidental version strings that includes that string (think username that includes "javac" for some reason, who are we to judge...).
>> Additional testing:
>> - [x] Affected test passes with default version string
>> - [x] Affected test fails with JDK-8266239 reverted
>> - [x] Affected test passes with `--with-version-opt=javac`
> I'm not a Reviewer, nor an expert in this area, but this change looks OK to me.
Thanks for review, @jaikiran. Any formal Reviewer wants to chime in? Would be nice to get GHA all green again.
More information about the compiler-dev