RFR: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record [v2]

Guoxiong Li gli at openjdk.java.net
Wed Sep 15 06:16:43 UTC 2021

On Wed, 15 Sep 2021 01:43:17 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Treat source as comment mistakenly. Remove the comment symbol.
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 1517:
>> 1515:                         // If the class type of the record component is generated by annotation processor, it should
>> 1516:                         // use the new actual class type and symbol instead of the old dummy ErrorType.
>> 1517:                         // toRemove = rc;
> there is dead code here, `toRemove` doesn't seem to be assigned ever, probably you uploaded an intermediate patch?

The `// toRemove = rc;` should be `toRemove = rc;`. It is a statement instead of a comment. I revised it mitakenly in my second commit `Polish`. In the second commit `Polish`, I only want to fix the indentation so that I didn't test again after revising. Unfortunately, the IDE changed `toRemove = rc;` to a comment. Apology for the mistake.


PR: https://git.openjdk.java.net/jdk/pull/5511

More information about the compiler-dev mailing list