RFR: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record [v3]

Guoxiong Li gli at openjdk.java.net
Thu Sep 16 12:24:28 UTC 2021

> Hi all,
> After processing annotation, if new source files are generated, the compiler should re-parse and re-enter the source files so that the type and symbol can keep right. The compiler always holds this convention in the past. But when the feature `record` is added, the convention is broken. In this bug, the compiler doesn't  catch or enter the new/good type for record component after processing annotation. So some issues may occur at the later phases.
> This patch fixes the type of the record component so that the phases `Gen` and `ClassWriter` can get the right type. And a test case is added.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong

Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Add test cases about unknown type and annotation.
 - Fix comments.
 - Merge branch 'master' into JDK-8273408
 - Treat source as comment mistakenly. Remove the comment symbol.
 - Polish
 - 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record


  - all: https://git.openjdk.java.net/jdk/pull/5511/files
  - new: https://git.openjdk.java.net/jdk/pull/5511/files/7b756883..f262a85c

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5511&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5511&range=01-02

  Stats: 904 lines in 89 files changed: 653 ins; 85 del; 166 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5511.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5511/head:pull/5511

PR: https://git.openjdk.java.net/jdk/pull/5511

More information about the compiler-dev mailing list