RFR: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record [v3]
vromero at openjdk.java.net
Thu Sep 16 15:15:46 UTC 2021
On Thu, 16 Sep 2021 12:24:28 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>> After processing annotation, if new source files are generated, the compiler should re-parse and re-enter the source files so that the type and symbol can keep right. The compiler always holds this convention in the past. But when the feature `record` is added, the convention is broken. In this bug, the compiler doesn't catch or enter the new/good type for record component after processing annotation. So some issues may occur at the later phases.
>> This patch fixes the type of the record component so that the phases `Gen` and `ClassWriter` can get the right type. And a test case is added.
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> - Add test cases about unknown type and annotation.
> - Fix comments.
> - Merge branch 'master' into JDK-8273408
> - Treat source as comment mistakenly. Remove the comment symbol.
> - Polish
> - 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
looks good, thanks for the additional research
Marked as reviewed by vromero (Reviewer).
More information about the compiler-dev