RFR: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record [v2]

Guoxiong Li gli at openjdk.java.net
Fri Sep 17 05:37:51 UTC 2021

On Wed, 15 Sep 2021 14:35:09 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Treat source as comment mistakenly. Remove the comment symbol.
> I think that there are two test cases missing here. I think that you should investigate the interaction of your patch with something like:
> record R(unknownType t) {}
> and see what happens, if your code creates another record component when I think it shouldn't, etc. Actually you could try to override the type in the existing record component instead of creating a new one.
> Another investigation you should do is how your code interacts with annotations (declaration and type anotations) on the record component. So in your test add annotations to the record component and see if you need to copy them etc. I think that if you override the type of the record component instead of creating a new one you should be fine with annotations, but not sure TBH

@vicente-romero-oracle Thanks for your review.


PR: https://git.openjdk.java.net/jdk/pull/5511

More information about the compiler-dev mailing list