RFR: JDK-8273244: Improve diagnostic output related to ErroneousTree [v3]
prappo at openjdk.java.net
Wed Sep 29 10:42:41 UTC 2021
On Wed, 29 Sep 2021 03:22:39 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Yes, and agreed.
> FWIW, I'm still in two minds whether this should be a switch or overriding methods. It's ... er, disappointing ... that the lack of support for `PROVIDES` and `USES` didn't "automatically" show up in testing. That may suggest a lack of coverage in the `DocTree` tests, which suggests the need for a test to check coverage.
For the sake of this review, using `switch` would be better: fewer changes, less cognitive load. Later we can think of ways of improving that code. It would be nice to structure it such that it would fail at compile time, if we forgot a case.
More information about the compiler-dev