<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Jon,<br>
</p>
<div class="moz-cite-prefix">On 2/21/2019 9:30 AM, Jonathan Gibbons
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:ef938550-7d39-d328-cb90-e90dd76f02e9@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>Mostly OK, but I think you've nullified/broken the test</p>
<p><a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/~darcy/8219254.3/test/langtools/tools/javac/6330997/T6330997.java.sdiff.html"
moz-do-not-send="true">http://cr.openjdk.java.net/~darcy/8219254.3/test/langtools/tools/javac/6330997/T6330997.java.sdiff.html</a></p>
<p>The test specifically comments: </p>
<pre style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;"> 27 * @summary javac should accept class files with major version of the next release</pre>
<p>And you've changed that behavior.</p>
</blockquote>
<p>As briefly noted earlier in the review thread, when I looked at
T6330997.java more closely, it doesn't actually need the
-source/-target values being set. The class files for minimal
source files are written out and then modified to bump the version
number. So all that is needed is that the files are compiled under
the current target, which can be implemented implicitly without
-source/-target options.</p>
<p>(I and others have updated this file without much consideration
for the last few version updates; better to leave it be if
possible!)</p>
<p>Thanks,<br>
</p>
<p>-Joe<br>
</p>
<br>
</body>
</html>