<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Looks good.</p>
<p>Wish we could (easily) use new features in tests (e.g. text
blocks) :-)</p>
<p>One small typo:</p>
<pre> 143 // negative control test: access fails without tyhe new option
</pre>
<div class="moz-cite-prefix">Cheers<br>
Maurizio</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 09/12/2019 22:07, Jonathan Gibbons
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:3f2b4afb-ac83-c769-0013-2b1c0115babf@oracle.com">Please
review a small localized change to javac, to extend the support
for the existing hidden -XDaccessInternalAPI option to plugins
provided as modules.
<br>
<br>
The change utilizes the existing ModuleHelper.addExports method.
<br>
<br>
The test is derived from the recent new test
AutostartPlugins.java. It creates a plugin in a jar file, in a
module on the module path, and in a module that is linked in to
the image. The test case for the classpath is not new and is just
provided for completeness. A negative test case for
plugin-as-module is provided, to demonstrate that access fails
without the option, and there are test cases for modules on the
module path and jlinked into an image.
<br>
<br>
The positive test cases just verify that non-null elements in task
events can be downcast to ClassSymbol, and an internal field (the
kind) accessed.
<br>
<br>
No CSR, since the option is undocumented, unsupported and subject
to change at any time.
<br>
<br>
-- Jon
<br>
<br>
JBS: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8235597">https://bugs.openjdk.java.net/browse/JDK-8235597</a>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jjg/8235597/webrev.00/">http://cr.openjdk.java.net/~jjg/8235597/webrev.00/</a>
<br>
<br>
<br>
</blockquote>
</body>
</html>