Logger.log should call getHandlers

Martin Buchholz martinrb at google.com
Tue Apr 14 02:15:06 UTC 2009

Hi Swamy

Our recent change

changeset:   810:6eac3829cb41
user:        martin
date:        Tue Jan 27 15:04:30 2009 -0800
summary:     6797480: Remove synchronization bottleneck in logger

unfortunately introduced a serious bug.

Logger.log should call Logger.getHandlers(), not Logger.handlers,
because getHandlers may be overriden in a subclass.
Notably, the root logger is such a subclass with a
non-trivial getHandlers method.

Here's the obvious fix, with a regression test that
includes "penance" for our having broken j.u.l.
by adding some much-needed  tests for never-before-exercised code.

Please review and file a bug.

PATCH is here:


More information about the core-libs-dev mailing list