Review request for 6810254 (v01)

Mandy Chung Mandy.Chung at Sun.COM
Wed Mar 11 21:10:40 UTC 2009

On 03/11/09 13:01, Alan Bateman wrote:
> Mandy Chung wrote:
>> David, Alan,
>> Thanks for your feedback.  I revise the fix per Alan's suggestion. I 
>> decide not to keep the fix to lazily initialize the shutdown hook 
>> only.  So, DeleteOnExitHook and 
>> java.lang.ApplicationShutdownHooks are only loaded when the app uses it.
>> Webrev at:
>> Thanks
>> Mandy
> This looks a lot better. One suggestion is to reverse the order of the 
> parameters to registerShutdownHook so that the Runnable is last. That 
> would make it easier to read and also easier to see the hook slot which 
> is the fragile part to the solution.

Ok. Will change the parameter order.

> Minor nit is that the comment in reads "The order in with 
> the hooks are added here is important ...". The registration order 
> doesn't matter now so this could be changed.

Right. Will update the comment.


> -Alan.

More information about the core-libs-dev mailing list