RFE 4519026: (process) Process should support Unicode on Win NT, request for review

Alan Bateman Alan.Bateman at Sun.COM
Mon Mar 23 17:55:41 UTC 2009

Martin Buchholz wrote:
> :
> We could make tests more robust by whitelisting a set of
> environment variables added back in after clear(),
> which would include SystemRoot on Windows, and perhaps
> likely suspects like PATH and KRB5CCNAME.
> Heiko, that would be a difficult change to get right,
> and perhaps impossible to get 100% right if you take
> into consideration environment variable values that
> don't survive round-trip decoding-encoding intact or
> that contain newlines.  So this would not be necessary
> to get my approval (it's a pre-existing test failure).
I agree.

I'm finally looking at the patch and it mostly look good. I'm not an 
expert on the Process code but is the directory already normalized at 
this point? Just wondering if all of getNativePath is needed.


More information about the core-libs-dev mailing list