Review request for 5049299

Martin Buchholz martinrb at
Sun May 24 01:20:40 UTC 2009

Two comments:


I would use _exit instead of standard exit in the process helper code,
as in the existing code, although unlike the existing code,
it doesn't seem to be a correctness issue.


I implemented


but should have tried to use confstr(_SC_PATH)

as in this example from the confstr manpage:

           char *pathbuf;
           size_t n;

           n = confstr(_CS_PATH,NULL,(size_t) 0);
           pathbuf = malloc(n);
           if (pathbuf == NULL)
           confstr(_CS_PATH, pathbuf, n);

Of course, only within
#ifdef _CS_PATH

That's a small portability bug that is worth
fixing now that the jdk sources are targeting more platforms.


On Fri, May 22, 2009 at 03:05, Michael McMahon <Michael.McMahon at>wrote:

> Hi,
> I have just posted a webrev for 5049299: (process) Use posix_spawn, not
> fork, on S10 to avoid swap exhaustion.
> webrev location:<>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the core-libs-dev mailing list