Code review request for 7002594 "Math.max and Math.min should use floatToRawIntBits() to check for -0.0"
mike.duigou at oracle.com
Wed Dec 1 18:47:04 UTC 2010
All looks good to me.
Understanding why the maxs check Double.doubleToRawLongBits(a) and the mins check Double.doubleToRawLongBits(b) required reading the javadoc. :-)
On Dec 1 2010, at 09:24 , Joe Darcy wrote:
> Please review my simple fix for
> 7002594 "Math.max and Math.min should use floatToRawIntBits() to check for -0.0"
> Besides addressing the reported issues with max/min, I also review the other uses of those methods in java.lang.* and added a comment or two. While looking over sun/misc/FpUtils.java, I took the opportunity to update the javadoc style.
More information about the core-libs-dev