code review request for 6880112, Coin: use diamond in core libraries
pbenedict at apache.org
Fri Dec 17 14:54:03 UTC 2010
Do it as two commits (one for diamond, the other for line formatting)
that way you can keep the work separate. You may even want 2 Sun
tracking issue in case you need to do several commits under one issue.
On Thu, Dec 16, 2010 at 10:43 PM, Joe Darcy <joe.darcy at oracle.com> wrote:
> On 12/16/2010 7:50 PM, Weijun Wang wrote:
>>> Unfortunately, as Kelly points out (and I've also verified this)
>>> changing the line breaks will change the .class file contents (though
>>> not the bytecodes). The original changeset does have a very nice
>>> property of not changing the .class files at all.
>> Maybe you can compile the codes without line number info and diff again?
> I don't think that extra step is necessary given the validation that has
> already been done.
More information about the core-libs-dev