PriorityQueue(collection) should throw NPE

Chris Hegarty chris.hegarty at
Fri May 7 10:50:36 UTC 2010

On 07/05/2010 11:47, David Holmes wrote:
> Hi Chris,
> Chris Hegarty said the following on 05/07/10 19:55:
>> Hi David, Martin,
>> Thanks for filing the bug David, I'll just add a link to the email
>> thread in the archive for reference.
> Thanks.
>> Just one minor observation while reviewing the changes. Is it
>> necessary for initFromPriorityQueue to call initFromCollection ( in
>> the case where you're given a PriorityQueue subclass), or can it
>> simply call initElementsFromCollection?
> It's possible that the subclass overrides toArray to return an array
> that doesn't preserve the internal order. Hence we need to re-sort,
> hence initFromCollection.

OK, not problem. Just checking.


> David

More information about the core-libs-dev mailing list