Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

Alan Bateman Alan.Bateman at
Mon Apr 11 18:19:47 UTC 2011

Lance Andersen - Oracle wrote:
> Hi all,
> This is a request for a review of the changes to remove the lint warnings for javax.sql.rowset.  The diff is at
In RowSetMetaDataImpl.wrap it might be better to test with 
iface.isInstance(this)) rather than catching the CCE?  At L937 it might 
be good to put the method declaration onto its own line (I assume a 
newline was gobbled up at some point).

In I notice the constants near the top aren't indented, 
might be worth fixing that "while you are in the area". Minor 
inconsistency but in the new type parameters you've got a space between 
the types in two places, and no space between them in the other place.

Otherwise the changes look okay to me.


PS: javac was updated recently to emit warnings for unreachable catch 
clauses and one place that generates this warning is 
src/share/classes/com/sun/rowset/ It would be 
great to get that one fixed while you are fixing the other warnings.

More information about the core-libs-dev mailing list