Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

Lance Andersen - Oracle lance.andersen at
Tue Apr 12 14:35:15 UTC 2011

Hi Alan, has your suggested  changes below. 

On Apr 12, 2011, at 4:08 AM, Alan Bateman wrote:

> Lance Andersen - Oracle wrote:
>> Hi Alan, Joe
>> I pushed the revised webrev out (webrev.01).  I am going through a directory at time to resolve the lint errors and found a few additional  classes to address in com.sun.rowset (as I had not looked at this directory yet)  which you will see in the change log.
> The updated changes look okay to me. A few minor comments:
> src/share/classes/com/sun/rowset/
> L120 - you want want to insert a line after the declaration of rvh.
> L296 and L301 - misaligned?
> L1287 - you could use the diamond operator here
> L2956 - I assume this can be Map rather than java.util.Map.
> src/share/classes/com/sun/rowset/
> L62 - end of comment is misaligned
> L225 - you could use the diamond operator here
> -Alan.

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at

More information about the core-libs-dev mailing list