Review request for 7034570 - java.lang.Runtime.exec(String cmd, String env) can not work properly if SystemRoot not inherited
Alan.Bateman at oracle.com
Thu Apr 14 14:56:51 UTC 2011
Michael McMahon wrote:
> An updated webrev is available for this fix. I'll probably go ahead
> with the CCC request for the spec. change anyway.
The updated webrev looks much better. A couple of minor suggestions
- it might be useful to future maintainers if you put a comment in
before the iteration to explain why SystemRoot is needed
- it might be neater to add an append(StringBuilder sb, String key,
String value) method to append the key=value\u0000 strings rather than
doing it in two places
- the string "systemroot" is in 3 places, might be nice to make it a
Otherwise looks fine to me.
More information about the core-libs-dev