Review (Updated) : 4884238 : Constants for Standard Charsets

Mike Duigou mike.duigou at
Mon Apr 18 22:24:06 UTC 2011

Hello All;

I have updated the webrev for the standard Charset constants based upon feedback received from the earlier reviews. The constants class is now named StandardCharset rather than Charsets in mimicry of the class naming used by NIO.2 (JSR 203). According to the conventions used by JSR 203 and elsewhere in JDK a "Charsets" class would be for static utility methods rather than solely constants.

The DEFAULT_CHARSET definition is also now removed. The Charset.getDefaultCharset() method makes it more clear that the value is not a constant across all all JVM instances.

Also now included is a small unit test and replacement of several uses of Charset.forname() for standard charset names within the platform.

The latest webrev :

Any other remaining feeback?


More information about the core-libs-dev mailing list