Review (Updated) : 4884238 : Constants for Standard Charsets

Alan Bateman Alan.Bateman at
Tue Apr 19 08:14:33 UTC 2011

Mike Duigou wrote:
> :
> The latest webrev :
> Any other remaining feeback?
> Mike
Given that it now only defines the constants for the standard charsets 
then I think the new name is better, although with static import then it 
might not matter too much.

I'm not sure whether we should use this in the zip code as we don't want 
this to causes the lesser used charsets to be loaded. It might be worth 
double checking the startup.

The test claims to have been brewed in 2010. The "infrastructure" pasted 
in at the end is another reminder that we should have had a standard 
Assert/equivalent class in the test suite.


More information about the core-libs-dev mailing list