Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

Ulf Zibis Ulf.Zibis at
Tue Apr 19 15:31:38 UTC 2011

Thanks for your feedback Michael.

One little nit:
I guess you have overseen to replace .append("=") by .append('=')

Am 19.04.2011 17:05, schrieb Michael McMahon:
> Ulf,
> On the usage of List vs [], my point was that the clarity, simplicity and safety
> provided by iterating over a Collection out-weighs any performance cost in this case,
> as compared with using an array. It makes little difference to
> the cost of creating an OS process.
> On moving the SYSTEMROOT constant to be a local variable inside toEnvironmentBlock(),
> on balance it probably does look neater.
> Since I have to regenerate the webrev to fix a problem I found with the testcase, I'm including
> that change and the change to the comment for emptyEnvironment(). But, at this stage, I have
> to move onto other work, and this is the last webrev for this fix, unless someone finds a bug ..

So too little time for the switch to inherit ProcessEnvironment from TreeMap.

> Thanks for the work you put into reviewing it.

My pleasure!


More information about the core-libs-dev mailing list