please review 7117612: warnings fixes in java.lang

Omair Majid omajid at
Mon Dec 5 22:09:20 UTC 2011


On 12/04/2011 08:02 PM, Stuart Marks wrote:
> Please review the following webrev submitted by Omair Majid, consisting
> of warnings fixes for a variety of files in java.lang.
> It looks pretty clean, but it would be good to get another pair of eyes
> on this since there is sometimes great subtlety in java.lang.
> My comments below.
> --
> java/lang/ warning: [try] auto-closeable
> resource AutoCloseable has a member method close() that could
> throw InterruptedException
> The warning here is kind of silly. The intent is to warn implementors of
> AutoCloseable not to throw InterruptedException. But this is an
> interface, not an implementation, and it's the AutoCloseable interface
> itself! We may want to rethink when the compiler emits this warning,
> instead of suppressing the warning in source code. Joe, what do you
> think about this?
> --
> Consider narrowing the scope of @SuppressWarnings by using a local
> variable.

I have posted a new webrev:

This includes all the changes from the feedback so far, as well as 
changes to ThreadLocal.

I will not be posting a patch for ClassValue since (as you kindly 
pointed out), others are making changes to it and removing some warnings 
too [1]. I suppose I will revisit it later (if warning fixes are still 
being accepted :D ).



More information about the core-libs-dev mailing list