review of 7117249: java.util warnings patches from LJC/Mike Barker

Alan Bateman Alan.Bateman at
Tue Dec 6 20:46:52 UTC 2011

On 06/12/2011 18:46, Michael Barker wrote:
> Hi,
> Attached is the latest LJC warnings patch.  I've merged all of the
> changes into a single patch.  The one I'm unsure of the comments on
> the @SuppressWarnings("deprecation") in the  I've been
> fairly terse and just mentioned that it's using the date
> methods/constructor.
I looked at the updated patch and it looks fine to me. There are other 
classes in j.u.jar and j.u.logging that also have warnings but fixing 
the warnings is the classes you've chosen is fine too. The comments on 
the @SuppressWarnings("deprecation") in ZipEntry look okay to me too.


More information about the core-libs-dev mailing list