review of 7117249: java.util warnings patches from LJC/Mike Barker
martijnverburg at gmail.com
Wed Dec 7 11:12:31 UTC 2011
Question on contributions, I assume that as the patch is coming from Mike,
his OCA covers the rest of us?
On Wednesday, 7 December 2011, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 07/12/2011 08:43, Michael Barker wrote:
>>> 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
>>> Reviewed-by: alanb, dholmes, forax, sherman, smarks
>>> Contributed-by: London Java Community and Michael Barker
>>> <mikeb01 at gmail.com>
>>> Since the changeset comment is baked for all eternity, :-) I wanted to
>>> sure I got it right before proceeding. But basically this is the last
>>> that needs to be resolved before I can push in the changes. Let me know.
>> All looks good to me.
> Michael - the Contributed-by line is usually the individual's name (+
mail address) or a list of names (and their mail addresses). I think Stuart
is suggesting that this would be better than "London Java Community".
More information about the core-libs-dev