Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException
sean.mullan at oracle.com
Fri Dec 9 16:07:18 UTC 2011
On 12/6/11 3:48 PM, Sebastian Sickelmann wrote:
> Am 05.12.2011 19:06, schrieb Sean Mullan:
>> On 12/2/11 11:02 AM, Sean Mullan wrote:
>>>>  Solution 1
>>>>  Solution 2
>> I definitely prefer solution 2. Just a few minor comments:
>> - Use the javadoc @inheritDoc tag instead of copying the javadoc for the
>> initCause method.
>> - PreventOverridingOfChaining
>> lines 68, 71: what do these comments mean?
>> one additional test that would be useful to add would be to call initCause twice
>> for those ctors that don't have a Throwable parameter, and make sure initCause
>> throws IllegalStateExc.
> Updated the webrev to include your review.
You didn't add the additional test that I thought would be useful - are you
going to add that? Otherwise, it looks good.
More information about the core-libs-dev