Code Review Request for Bug #7089443

Charles Lee littlee at
Tue Dec 13 02:26:07 UTC 2011

On 12/13/2011 06:50 AM, Darryl Mocek wrote:
> Hello.  Please review this patch to fix InetAddress.getLocalHost fails 
> if the host name is larger HOST_NAME_MAX.  The fix is to use strncpy, 
> and supply the max length the host name can be, instead of using 
> strcpy.  There is no test supplied for this fix as I was unable to set 
> the host name larger then MAXHOSTNAMELEN on the Linux and Solaris 
> machines I tried.  I tested the fix by adding code to 
> Inet4AddressImpl.c to simulate a host name larger then MAXHOSTNAMELEN.
> Webrev, can be found here: 
> Thanks,
> Darryl
Hi Darryl,

I have changed Inet4AddressImpl.c a lot in the commit:

changeset:   4757:81987765cb81
user:        ngmr
date:        Fri Nov 11 14:40:18 2011 +0000
summary:     7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo

and you can find the webrev here:

Would you please use the latest version of Inet4AddressImpl.c ?

Yours Charles

More information about the core-libs-dev mailing list