Code Review Request for Bug #7089443

Darryl Mocek darryl.mocek at
Tue Dec 13 18:35:30 UTC 2011


    thanks for the notification.  I was scratching my head trying to 
figure out why I was seeing the old code and not the new.  Being new to 
Mercurial and after some digging, I realized I was using 'up' the way I 
used it in Subversion (pull from the repo and update the local copy), 
the tool I've been using up to now.  After reading the docs I realize I 
need to do a pull in Mercurial first.

   Your commit indeed looks like it fixes the bug, I'll mark the bug 
report as appropriate.


On 12/12/2011 06:26 PM, Charles Lee wrote:
> On 12/13/2011 06:50 AM, Darryl Mocek wrote:
>> Hello.  Please review this patch to fix InetAddress.getLocalHost 
>> fails if the host name is larger HOST_NAME_MAX.  The fix is to use 
>> strncpy, and supply the max length the host name can be, instead of 
>> using strcpy.  There is no test supplied for this fix as I was unable 
>> to set the host name larger then MAXHOSTNAMELEN on the Linux and 
>> Solaris machines I tried.  I tested the fix by adding code to 
>> Inet4AddressImpl.c to simulate a host name larger then MAXHOSTNAMELEN.
>> Webrev, can be found here: 
>> Thanks,
>> Darryl
> Hi Darryl,
> I have changed Inet4AddressImpl.c a lot in the commit:
> changeset:   4757:81987765cb81
> user:        ngmr
> date:        Fri Nov 11 14:40:18 2011 +0000
> summary:     7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo
> and you can find the webrev here: 
> Would you please use the latest version of Inet4AddressImpl.c ?

More information about the core-libs-dev mailing list