Request for review: 7123582: (launcher) display the -version and -XshowSettings

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Fri Dec 23 14:36:24 UTC 2011


> On 23/12/2011 02:22, Kumar Srinivasan wrote:
>> Hi,
>> This fixes a bug in launcher where showSettings in conjunction with 
>> -version
>> will do both and exit successfully. Thanks to Sean for pointing this 
>> out.
>> Here is the webrev:
>> Thanks
>> Kumar
> Looks okay to me except in the test where runTest7123582 is named 
> differently to the other run* methods in this test.
The others were part of the feature, but this one is a regression.

These comprehensive tests become a pain in the future to determine
when a particular method maps to a CR, so we tend to use a
comment with CR in these places, but comments sometimes get lost
when shuffling code around, by naming the method with a CR makes
it self-explanatory.


> -Alan

More information about the core-libs-dev mailing list