review request for 7021582, use try-with-resources in jar/zip implementation and tests
stuart.marks at oracle.com
Fri Feb 25 04:32:43 UTC 2011
On 2/24/11 5:17 PM, Kumar Srinivasan wrote:
> All the changes look good, the regression test
> jdk/test/tools/pack200 and jdk/test/tools/jar
> must be run, as jprt does not run these by default,
> also suggest a full control build using jdk, deploy and install.
Thanks for looking at the changes. What I'll do is separate out the pack200
changes and file a bug and create a separate webrev for them. That way I can
push the other changes while we do the additional testing for pack200.
>> So, if intrinsic.properties isn't found, what should happen? Ignore this
>> (seems like a bad idea); issue warning message (how?); throw something like
>> FileNotFoundException? Well, static initializers can't throw checked
>> exceptions, so maybe throw a RuntimeException with a suitable message?
> RE will be fine here, as you have already detected this condition should never
> unless there was a build issue.
OK, I'll have it throw a RuntimeException with a suitable message.
Thanks. I'll let you know how the testing goes.
>> Advice appreciated.
More information about the core-libs-dev