7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out
joe.darcy at oracle.com
Mon Jun 20 03:17:30 UTC 2011
Alan Bateman wrote:
> Rémi Forax wrote:
>> Looks good.
>> By the way, why javax.naming.Context was not retrofitted
>> to implement AutoCloseable.
> Thanks Rémi, thanks Vinnie.
> I was wondering about Context too as it appears, on the surface
> anyway, that it could extend AutoCloseable. I believe Joe used an
> annotation processor to identify candidates but there may have been
> some reason why this one wasn't changed.
I consulted my records on this type. It was found by the annotation
processor. Alan suspected the use of the type didn't fit well with the
try-with-resources idiom, but Vinnie was on vacation at the time and I
seemed to have failed to follow-up with Vinnie afterward to confirm.
Better late than never, Vinnie, do you think this type would benefit
from being used in the try-with-resources statement? If so, we can
retrofit it to implement AutoCloseable.
More information about the core-libs-dev