Review request: 7006814 "sun.util.logging.PlatformLogger ability to override the output format"
Alan.Bateman at oracle.com
Thu Mar 10 15:44:20 UTC 2011
Mandy Chung wrote:
> Are you suggesting to have SimpleFormatter to support controling the
> one-line format vs the current 2-line format?
Yes, that's what I was wondering about as it seems a bit strange that we
can configure the platform logger to generate one-line output but not
SimpleFormatter (at least not without creating a formatter and
configuring ConsoleHandler.formatter). It sounds like 6381464 isn't
really fixable out of concerns for existing log file parsers, in which
case maybe it should be closed.
On the webrev, then the changes looks reasonable to me. It doesn't look
like getCurrentTime needs to cache the Date object. On the property it
looks like you have to explicitly set it to "true" to be effective, ie:
can't "java -Dsun.util.logging.oneLineFormat Foo". Might be nicer to
rename to something like useOneLineFormat and default it to true when
the value is the empty string (just a suggestion).
More information about the core-libs-dev