Review Request -- 5045147 : When TreeMap is empty explicitly check for null keys in put() [updated]
Alan.Bateman at oracle.com
Mon Mar 14 21:09:45 UTC 2011
Mike Duigou wrote:
> I've gotten feedback regarding this issue and I've updated the webrev to use the commented out compare(key, key) test rather than the previously committed solution. I hadn't looked at the commented out code too carefully and had assumed it was pseudo-code rather than an actual solution. It's an improvement over the original solution and reads, to me and apparently others, a lot simpler.
> Also now included is a jtreg unit test.
This looks much better. On the test it might be better to give it a real
name, maybe Nulls or NullsAndEmptyMaps. Also looks like the bugID is
missing a "4" in the comment at L42 and L69.
More information about the core-libs-dev