Review Request -- 5045147 : When TreeMap is empty explicitly check for null keys in put() [updated]

Mike Duigou mike.duigou at
Tue Mar 15 16:34:00 UTC 2011

On Mar 15 2011, at 02:36 , Steve Poole wrote:

> On 14/03/11 21:02, Mike Duigou wrote:
>> I've gotten feedback regarding this issue and I've updated the webrev to use the commented out compare(key, key) test rather than the previously committed solution. I hadn't looked at the commented out code too carefully and had assumed it was pseudo-code rather than an actual solution. It's an improvement over the original solution and reads, to me and apparently others, a lot simpler.
> Hi - can you post the feedback to the mailing list?

Hi Steve;

Sorry, I can't repost them. I'd have preferred that the feedback went to the list but for whatever reasons the two respondents chose to send the feedback privately and I won't repost their private emails. (They are certainly welcome to do so if they feel it matters). Perhaps it was just a case of "Reply to Sender" vs "Reply to All". I don't know. To summarize the messages though, "Just use the commented out code for 504517. It's better than the old patch."


>> Also now included is a jtreg unit test.
>> Mike

More information about the core-libs-dev mailing list