7030249: Eliminate use of LoadLibrary and other clean-ups
kelly.ohair at oracle.com
Mon Mar 28 16:14:42 UTC 2011
I'll admit that I'm not following this C code horribly well, but overall it does look much cleaner.
As well as I can follow it, it looks good.
In the Makefile, could we get some comments as to why the lib's are needed and also some
comments as to what the delayload means and why it is important? I could guess, but I'd prefer
some makefile comments to help the next poor soul looking at it. ;^)
Windows native code is like living on another planet. :^(
On Mar 28, 2011, at 8:58 AM, Alan Bateman wrote:
> There are several places in the Windows native code where win32 functions are looked up with GetProcAddress after loading the DLL. Many of these places date back to when the JDK was built on Windows NT. Chris removed several of them from the network code in a recent change-set where he was cleaning up some code in that area. While editing java_props_md.c I also changed the code that uses GetUserName to get the value for the user.name property it's not set by an environment variable. This was something Dmytro Sheyko pointed out on this list a few weeks ago . The webrev with the changes is here:
> Vinnie - I updated the MS CAPI provider while I was at it, do you mind reviewing that? I've run the tests in test/sun/security/mscapi to verify.
>  http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-February/005837.html
More information about the core-libs-dev