code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

Charles Lee littlee at
Tue Nov 1 13:54:40 UTC 2011

On 10/29/2011 02:13 AM, Seán Coffey wrote:
> This is a second stab at cleaning up the close() and finalize() 
> methods for  FileInputStream / FileOutputStream / RandomAccessFile 
> classes so that all parents/referents sharing the same native 
> FileDescriptor are closed out correctly.
> With Alan's assistance, we have a better implementation in place where 
> we avoid the use of counters and instead cycle through a list of 
> shared closeables when a FileDescriptor is being shared.
> Bug report (not visible yet) 
> webrev :
> regards,
> Sean.
Hi Sean,

If we have 3 FileInputStream which share the same FileDescriptor, and 
one of the FileInputStream calls its own close. Will other 2 
FileInputStream close?

I see fd.closeAll is called in the close of FileInputStream, I guess it 
will close all the things which shared the same fd.

Yours Charles

More information about the core-libs-dev mailing list